-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect Straight Join in Vitess query planning #15528
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
@@ -187,26 +187,6 @@ func TestSubQueriesOnOuterJoinOnCondition(t *testing.T) { | |||
} | |||
} | |||
|
|||
func TestPlannerWarning(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, straight_join
no longer produces a warning, and we don't have reliable ways of getting warnings from the planner without turning off schema tracking
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15528 +/- ##
==========================================
+ Coverage 65.71% 65.74% +0.03%
==========================================
Files 1560 1560
Lines 194484 194562 +78
==========================================
+ Hits 127798 127916 +118
+ Misses 66686 66646 -40 ☔ View full report in Codecov by Sentry. |
Description
This PR adds the feature requested in #15527.
After these changes, Vitess respects the order of tables specified in queries using straight joins.
Related Issue(s)
Checklist
Deployment Notes