-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error message for planned reparent shard #15529
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Signed-off-by: Manan Gupta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15529 +/- ##
==========================================
- Coverage 67.41% 65.72% -1.70%
==========================================
Files 1560 1560
Lines 192752 194552 +1800
==========================================
- Hits 129952 127875 -2077
- Misses 62800 66677 +3877 ☔ View full report in Codecov by Sentry. |
Description
This PR fixes the issue described in #15380.
In
PlannedReparentShard
we now give a more descriptive error message telling exactly why the tablets cannot be promoted. Post these changes, the error message now looks like -Related Issue(s)
Checklist
Deployment Notes