Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message for planned reparent shard #15529

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Mar 20, 2024

Description

This PR fixes the issue described in #15380.
In PlannedReparentShard we now give a more descriptive error message telling exactly why the tablets cannot be promoted. Post these changes, the error message now looks like -

cannot find a tablet to reparent to
zone1-0000000100 does not match the new primary alias provided
zone1-0000000101 does not match the new primary alias provided
zone2-0000000102 is not a replica
zone1-0000000103 is not in the same cell as the previous primary
zone1-0000000104 has 1m40s replication lag which is more than the tolerable amount

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Cluster management labels Mar 20, 2024
Copy link
Contributor

vitess-bot bot commented Mar 20, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 20, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 20, 2024
@GuptaManan100 GuptaManan100 removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 20, 2024
@GuptaManan100 GuptaManan100 changed the title feat: fix error message for planned reparent shard Fix error message for planned reparent shard Mar 20, 2024
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

go/vt/vtctl/reparentutil/util.go Outdated Show resolved Hide resolved
Signed-off-by: Manan Gupta <[email protected]>
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.72%. Comparing base (696fe0e) to head (6693c85).
Report is 136 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15529      +/-   ##
==========================================
- Coverage   67.41%   65.72%   -1.70%     
==========================================
  Files        1560     1560              
  Lines      192752   194552    +1800     
==========================================
- Hits       129952   127875    -2077     
- Misses      62800    66677    +3877     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuptaManan100 GuptaManan100 merged commit ae066f6 into vitessio:main Mar 21, 2024
102 checks passed
@GuptaManan100 GuptaManan100 deleted the error-message-fix branch March 21, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Reparent error message ambiguous
3 participants