Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: dedicated pool dialers to vtorc and to throttler functions, removing "concurrency" #15559

Closed
wants to merge 5 commits into from

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Mar 24, 2024

Description

Yet another alternative approach to #15541 and to #15520. In this PR:

  • We have different poolDialers, which do not share resources. We have one general purpose one ; another, dedicated to vtorc ; another, dedicated to the tablet throttler.
  • dialPool function returns an invalidator, much like Fix for FullStatus gRPC connection pooling #15520. However, only FullStatus and CheckThrottler choose to invoke it. When they do, they do not affect any other pool dialer.
  • I got rid of the concurrency setting. It's still there, but unused. It's misleading (more writeup in an upcoming issue).

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Mar 24, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 24, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 24, 2024
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 82.50000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 65.74%. Comparing base (a06cf7d) to head (8035926).
Report is 2 commits behind head on main.

Files Patch % Lines
go/vt/vttablet/grpctmclient/client.go 82.50% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15559   +/-   ##
=======================================
  Coverage   65.73%   65.74%           
=======================================
  Files        1560     1560           
  Lines      194592   194605   +13     
=======================================
+ Hits       127917   127944   +27     
+ Misses      66675    66661   -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shlomi-noach shlomi-noach changed the title WIP: dedicated pool dialers to vtorc and to throttler functions. WIP: dedicated pool dialers to vtorc and to throttler functions, removing "concurrency" Mar 24, 2024
@shlomi-noach
Copy link
Contributor Author

Between this PR and #15560, we prefer #15560 at this time, and we will deal with the concurrency question in a later change.

@shlomi-noach shlomi-noach deleted the tmc-pool-dialer-3 branch March 24, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: TabletManager Component: Throttler Component: VTorc Vitess Orchestrator integration NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants