-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: dedicated pool dialers to vtorc
and to throttler functions, removing "concurrency"
#15559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
added
Type: Bug
Component: VTorc
Vitess Orchestrator integration
Component: TabletManager
Component: Throttler
labels
Mar 24, 2024
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Mar 24, 2024
5 tasks
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15559 +/- ##
=======================================
Coverage 65.73% 65.74%
=======================================
Files 1560 1560
Lines 194592 194605 +13
=======================================
+ Hits 127917 127944 +27
+ Misses 66675 66661 -14 ☔ View full report in Codecov by Sentry. |
Closed
5 tasks
shlomi-noach
changed the title
WIP: dedicated pool dialers to
WIP: dedicated pool dialers to Mar 24, 2024
vtorc
and to throttler functions.vtorc
and to throttler functions, removing "concurrency"
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: TabletManager
Component: Throttler
Component: VTorc
Vitess Orchestrator integration
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Yet another alternative approach to #15541 and to #15520. In this PR:
vtorc
; another, dedicated to the tablet throttler.dialPool
function returns aninvalidator
, much like Fix for FullStatus gRPC connection pooling #15520. However, onlyFullStatus
andCheckThrottler
choose to invoke it. When they do, they do not affect any other pool dialer.concurrency
setting. It's still there, but unused. It's misleading (more writeup in an upcoming issue).Related Issue(s)
poolDialer
#15563TabletManagerClient
real pool dialer #15541Checklist
Deployment Notes