Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-19.0] Dedicated poolDialer logic for VTOrc, throttler (#15562) #15567

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Mar 26, 2024

Description

This is a backport of #15562

@vitess-bot vitess-bot bot added Backport This is a backport Component: TabletManager Component: Throttler Component: VTorc Vitess Orchestrator integration Merge Conflict Skip CI Skip CI actions from running Type: Bug labels Mar 26, 2024
Copy link
Contributor Author

vitess-bot bot commented Mar 26, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

Copy link
Contributor Author

vitess-bot bot commented Mar 26, 2024

Hello @shlomi-noach, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 15567 -R vitessio/vitess
git reset --hard origin/release-19.0
git cherry-pick -m 1 90c005775353401710768899f3b77257696f0c15

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 26, 2024
@github-actions github-actions bot added this to the v19.0.2 milestone Mar 26, 2024
Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach shlomi-noach removed Skip CI Skip CI actions from running NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request Merge Conflict NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 26, 2024
@shlomi-noach shlomi-noach marked this pull request as ready for review March 26, 2024 06:19
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 82.69231% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 67.43%. Comparing base (8ee3294) to head (3f307f8).

Files Patch % Lines
go/vt/vttablet/grpctmclient/client.go 82.69% 9 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #15567      +/-   ##
================================================
- Coverage         67.43%   67.43%   -0.01%     
================================================
  Files              1560     1560              
  Lines            192619   192662      +43     
================================================
+ Hits             129894   129922      +28     
- Misses            62725    62740      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shlomi-noach shlomi-noach merged commit 5950765 into release-19.0 Mar 26, 2024
199 checks passed
@shlomi-noach shlomi-noach deleted the backport-15562-to-release-19.0 branch March 26, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants