-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Replace t.fatalf
with testify require
in go/vt/schemamanager
#15600
Merged
GuptaManan100
merged 1 commit into
vitessio:main
from
beingnoble03:test-vt-schemamanager
Apr 2, 2024
Merged
test: Replace t.fatalf
with testify require
in go/vt/schemamanager
#15600
GuptaManan100
merged 1 commit into
vitessio:main
from
beingnoble03:test-vt-schemamanager
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noble Mittal <[email protected]>
beingnoble03
added
Type: Internal Cleanup
Type: Testing
Component: General
Changes throughout the code base
labels
Mar 31, 2024
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Mar 31, 2024
beingnoble03
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Mar 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15600 +/- ##
==========================================
- Coverage 65.78% 65.78% -0.01%
==========================================
Files 1561 1561
Lines 194838 194838
==========================================
- Hits 128171 128169 -2
- Misses 66667 66669 +2 ☔ View full report in Codecov by Sentry. |
frouioui
reviewed
Apr 1, 2024
frouioui
approved these changes
Apr 1, 2024
GuptaManan100
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces some
t.fatalf
instances with testify'srequire
ingo/vt/schemamanager
Related Issue(s)
t.Errorf
andt.Fatalf
withassert
andrequire
, respectively #15182Checklist
Deployment Notes