Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MySQL/Percona from the vitess/lite Docker image #15605

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Remove MySQL/Percona from the vitess/lite Docker image #15605

merged 3 commits into from
Apr 2, 2024

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Apr 1, 2024 •
edited
Loading

Description

This Pull Request is a follow up of #14990. In v20.0.0 we want to remove mysqld from the vitess/lite image and remove the version-sepcific tags too.

Related Issue

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 1, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 1, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Apr 1, 2024
@frouioui frouioui force-pushed the remove-deprecated-images branch from 846c769 to 36ebcf0 Compare April 1, 2024 21:46
@codecov Codecov
Copy link

codecov bot commented Apr 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.14%. Comparing base (fabd746) to head (650f593).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15605      +/-   ##
==========================================
+ Coverage   65.80%   68.14%   +2.33%     
==========================================
  Files        1561     1562       +1     
  Lines      195220   197558    +2338     
==========================================
+ Hits       128474   134625    +6151     
+ Misses      66746    62933    -3813

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui
Remove MySQL/Percona lite tags
cd31ff4 
Signed-off-by: Florent Poinsard <[email protected]>

Switch from root to vitess users when installing packages

Signed-off-by: Florent Poinsard <[email protected]>

debug - use frouioui as the docker account

Signed-off-by: Florent Poinsard <[email protected]>

debug - use frouioui for the lite image

Signed-off-by: Florent Poinsard <[email protected]>

revert wip and debug

Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui force-pushed the remove-deprecated-images branch from fcef212 to cd31ff4 Compare April 1, 2024 22:35
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Docker and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 1, 2024
@frouioui frouioui marked this pull request as ready for review April 1, 2024 23:00
@frouioui frouioui mentioned this pull request Apr 1, 2024
Closed
deepthi
deepthi reviewed Apr 1, 2024
View reviewed changes
docker/lite/Dockerfile.ubi7
@@ -1,11 +1,11 @@
# Copyright 2019 The Vitess Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the renames in this folder are weird. Did you actually use git mv to rename these files? Or is GH inferring them as renames because of the similarity of content?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter

dbussink
dbussink reviewed Apr 2, 2024
View reviewed changes
docker/local/Dockerfile
@@ -7,7 +7,7 @@ RUN apt-get update
RUN apt-get install -y sudo curl vim jq

# Install dependencies
COPY docker/lite/install_dependencies.sh /vt/dist/install_dependencies.sh
COPY docker/utils/install_dependencies.sh /vt/dist/install_dependencies.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to have this script? It installs a number of packages, but are all those packages still relevant? or should we clean more in there too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script is now only used by the local and vttestserver images so it is fine to keep it as it is since we still require mysqld/percona-server on those images.

@frouioui frouioui merged commit 002ac54 into main Apr 2, 2024
206 checks passed
@frouioui frouioui deleted the remove-deprecated-images branch April 2, 2024 14:21
@frouioui frouioui mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@dbussink dbussink dbussink approved these changes

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Component: Docker Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.

Remove MySQL/Percona from the vitess/lite image
3 participants
@frouioui @dbussink @deepthi