-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TPCH test by providing the correct field information in evalengine #15623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Apr 3, 2024
GuptaManan100
added
Component: Query Serving
Type: Testing
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Apr 3, 2024
Signed-off-by: Manan Gupta <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15623 +/- ##
=======================================
Coverage 68.12% 68.12%
=======================================
Files 1556 1556
Lines 194984 195019 +35
=======================================
+ Hits 132840 132865 +25
- Misses 62144 62154 +10 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
changed the title
Add tpch test to e2e package
Fix TPCH test by providing the correct field information in evalengine
Apr 4, 2024
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
requested review from
frouioui,
rohit-nayak-ps,
deepthi,
mattlord,
harshit-gangal and
systay
as code owners
April 4, 2024 08:16
systay
reviewed
Apr 4, 2024
systay
reviewed
Apr 4, 2024
vmg
approved these changes
Apr 4, 2024
GuptaManan100
added
the
Backport to: release-19.0
Needs to be back ported to release-19.0
label
Apr 4, 2024
systay
approved these changes
Apr 4, 2024
Signed-off-by: Manan Gupta <[email protected]>
This audits more cases in the evalengine where we create datetime related or decimal types and ensures we initialize them with the correct sizing. This is necessary to ensure that the type information is correct further downstream also for the evalengine compiler since there are cases where we have to type switch based in input sizes. Signed-off-by: Dirkjan Bussink <[email protected]>
GuptaManan100
added a commit
that referenced
this pull request
Apr 4, 2024
#15623) Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]>
frouioui
pushed a commit
that referenced
this pull request
Apr 4, 2024
…on in evalengine (#15623) (#15655) Signed-off-by: Manan Gupta <[email protected]> Signed-off-by: Dirkjan Bussink <[email protected]> Co-authored-by: Manan Gupta <[email protected]> Co-authored-by: Dirkjan Bussink <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-19.0
Needs to be back ported to release-19.0
Component: Query Serving
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue described in #15643
While investigating the issue, it was found that we weren't copying the column length and the scale from the fields information we got back from MySQL. This caused evalengine to mess up the calculation of the final scale in the output columns.
This PR adds the tests to our infrastructure. It also adds a unit test and then fixes the bug.
Related Issue(s)
Checklist
Deployment Notes