Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-18.0] VReplication: Fix workflow update changed handling (#15621) #15628

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Apr 3, 2024

Description

This is a backport of #15621

@vitess-bot vitess-bot bot added Backport This is a backport Component: VReplication Merge Conflict Skip CI Skip CI actions from running Type: Bug labels Apr 3, 2024
Copy link
Contributor Author

vitess-bot bot commented Apr 3, 2024

Hello @mattlord, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 15628 -R vitessio/vitess
git reset --hard origin/release-18.0
git cherry-pick -m 1 0e2f1751d470da9d17f6c1c7bfb381ba6676117d

Copy link
Contributor Author

vitess-bot bot commented Apr 3, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord removed Skip CI Skip CI actions from running Merge Conflict labels Apr 3, 2024
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord marked this pull request as ready for review April 3, 2024 20:08
@mattlord mattlord requested a review from rohit-nayak-ps as a code owner April 3, 2024 20:08
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord force-pushed the backport-15621-to-release-18.0 branch 3 times, most recently from d69d323 to f2fbd4d Compare April 3, 2024 22:00
@mattlord mattlord merged commit 903dce9 into release-18.0 Apr 3, 2024
203 checks passed
@mattlord mattlord deleted the backport-15621-to-release-18.0 branch April 3, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants