Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue building base/k8s when tag version is below v20 #15638

Merged
merged 10 commits into from
Apr 4, 2024

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Apr 3, 2024

Description

Fix various bug found after merging #15620:

  • We still want to build base and k8s on older tags (<v20)
  • Some files were not copied properly between the bootstrap image and the lite image

Validated in CI: https://github.com/vitessio/vitess/actions/runs/8547164210/job/23418901908?pr=15638

frouioui added 5 commits April 3, 2024 16:52
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Copy link
Contributor

vitess-bot bot commented Apr 3, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 3, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Apr 3, 2024
frouioui added 4 commits April 3, 2024 17:32
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui added Type: Bug Component: Build/CI and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 4, 2024
Signed-off-by: Florent Poinsard <[email protected]>
Comment on lines +1 to +3
name: Docker Build Base (<v20)
on:
push:
Copy link
Member Author

@frouioui frouioui Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pure copy of what we used to have before #15620, only the workflow name and the tags-ignore field on lines 4 and 5 changed.

Comment on lines +1 to +3
name: Docker Build Lite (<v20)
on:
push:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@frouioui frouioui marked this pull request as ready for review April 4, 2024 00:21
@frouioui frouioui requested a review from rohit-nayak-ps as a code owner April 4, 2024 00:21
@deepthi
Copy link
Member

deepthi commented Apr 4, 2024

I assume that the reason you are having to do this is because our releases always use tooling from main? Otherwise, things should keep working on release branches, no? We should plan to fix this properly.

@frouioui
Copy link
Member Author

frouioui commented Apr 4, 2024

I assume that the reason you are having to do this is because our releases always use tooling from main? Otherwise, things should keep working on release branches, no?

IIRC when pushing a new tag, GitHub Actions will use the workflows found on the main branch. Not the workflows found on the tag's commit.

@frouioui frouioui merged commit a4513d0 into main Apr 4, 2024
199 checks passed
@frouioui frouioui deleted the re-add-docker-build-ci branch April 4, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants