Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemadiff: SubsequentDiffStrategy: allow/reject multiple changes on same entity #15675

Merged

Conversation

shlomi-noach
Copy link
Contributor

Description

Some diffs between two tables, cannot be applied in MySQL in a single ALTER TABLE statement. Examples:

  • Adding a column and dropping a partition.
  • Adding and dropping a partition.
  • Some other partitioning change scenarios.
  • Adding two FULLTEXT keys.

These are MySQL limitations. Specifically for FULLTEXT, schemadiff offers a flag to tolerate multiple changes (and vitess Online DDL can then work with that).

This PR adds a more general diff hint: whether to at all allow multiple changes per table (default: allow, for backwards compatibility), or to outright reject such diff.

This can only ever apply to ALTER TABLE as no other supported change has this problem (e.g. ALTER VIEW is just one sweep atomic change anyway ; DROP TABLE obviously has nothing to apply twice, etc.)

The new hint flag will be used in followup PRs. This PR is worth being standalone.

Related Issue(s)

#15674

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) labels Apr 8, 2024
@shlomi-noach shlomi-noach requested a review from deepthi as a code owner April 8, 2024 09:57
Copy link
Contributor

vitess-bot bot commented Apr 8, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 8, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Apr 8, 2024
@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 8, 2024
@shlomi-noach shlomi-noach requested a review from a team April 9, 2024 05:17
@shlomi-noach shlomi-noach merged commit 0912690 into vitessio:main Apr 11, 2024
105 of 113 checks passed
@shlomi-noach shlomi-noach deleted the schemadiff-subsequent-diff-strategy branch April 11, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants