Cleanup usage of FLUSH PRIVILEGES #15700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can remove usage of `FLUSH PRIVILEGES` in many places by making sure we only use the correct SQL functionality for managing users. If we don't modify the `mysql.user` table directly, we don't need to use `FLUSH PRIVILEGES`. Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
added
Type: Internal Cleanup
Component: General
dbussink
requested review from
deepthi,
GuptaManan100,
rohit-nayak-ps,
shlomi-noach,
frouioui and
mattlord
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
dbussink
commented
Apr 11, 2024
| # Care should be taken to change these users and passwords | ||
| # for production. | ||
| ############################################################################### | ||
|
|
There was a problem hiding this comment.
Do we want to keep this warning? We no longer have static secrets in this file anymore, which is a really good thing so the current warning is no longer accurate.
There was a problem hiding this comment.
I think we can/should remove it.
dbussink
removed
NeedsDescriptionUpdate
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15700 +/- ##
==========================================
- Coverage 68.40% 68.39% -0.02%
==========================================
Files 1556 1556
Lines 195121 195121
==========================================
- Hits 133479 133450 -29
- Misses 61642 61671 +29 ☔ View full report in Codecov by Sentry. |
mattlord
approved these changes
Apr 12, 2024
| # Care should be taken to change these users and passwords | ||
| # for production. | ||
| ############################################################################### | ||
|
|
There was a problem hiding this comment.
I think we can/should remove it.
shlomi-noach
approved these changes
Apr 14, 2024
| # Disable remote root access (only allow UNIX socket). | ||
| DELETE FROM mysql.user WHERE User = 'root' AND Host != 'localhost'; | ||
| # Remove anonymous users & disable remote root access (only allow UNIX socket). | ||
| DROP USER IF EXISTS ''@'%', ''@'localhost', 'root'@'%'; |
There was a problem hiding this comment.
Technically this statement is not equivalent to the original one, because it will not remove e.g. 'root'@'10.0.0.1', but fine.
There was a problem hiding this comment.
@shlomi-noach yeah, I don’t think they normally would exist by default right?
There was a problem hiding this comment.
That's right. I think it's good to merge.
| # Disable remote root access (only allow UNIX socket). | ||
| DELETE FROM mysql.user WHERE User = 'root' AND Host != 'localhost'; | ||
| # Remove anonymous users & disable remote root access (only allow UNIX socket). | ||
| DROP USER IF EXISTS ''@'%', ''@'localhost', 'root'@'%'; |
There was a problem hiding this comment.
Same. Not a concern as these are examples.
GuptaManan100
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can remove usage of
FLUSH PRIVILEGESin many places by making sure we only use the correct SQL functionality for managing users. If we don't modify themysql.usertable directly, we don't need to useFLUSH PRIVILEGES.Checklist