Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Improve query buffering behavior during MoveTables traffic switching #15701

Merged
merged 14 commits into from
Apr 25, 2024
+428 −208

Minor adjustment after merging in origin/main

7c8d572
Select commit
Loading
Failed to load commit list.
Merged

VReplication: Improve query buffering behavior during MoveTables traffic switching #15701

Minor adjustment after merging in origin/main
7c8d572
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 24, 2024 in 0s

68.42% (-0.02%) compared to 4c2df48

View this Pull Request on Codecov

68.42% (-0.02%) compared to 4c2df48

Details

Codecov Report

Attention: Patch coverage is 31.52174% with 63 lines in your changes are missing coverage. Please review.

Project coverage is 68.42%. Comparing base (4c2df48) to head (7c8d572).

Files Patch % Lines
go/vt/discovery/keyspace_events.go 22.22% 35 Missing ⚠️
go/vt/vtgate/plan_execute.go 57.14% 9 Missing ⚠️
go/vt/topo/etcd2topo/watch.go 60.00% 4 Missing ⚠️
go/vt/vtctl/workflow/traffic_switcher.go 0.00% 4 Missing ⚠️
go/vt/vtctl/workflow/server.go 0.00% 3 Missing ⚠️
go/vt/vtctl/workflow/switcher_dry_run.go 0.00% 3 Missing ⚠️
go/vt/vtctl/workflow/switcher.go 0.00% 2 Missing ⚠️
go/vt/vtgate/buffer/buffer.go 0.00% 2 Missing ⚠️
go/vt/vtgate/buffer/flags.go 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15701      +/-   ##
==========================================
- Coverage   68.44%   68.42%   -0.02%     
==========================================
  Files        1558     1558              
  Lines      195822   195865      +43     
==========================================
- Hits       134025   134024       -1     
- Misses      61797    61841      +44

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov