Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen4 Planner: support aggregate UDFs #15710

Merged
merged 9 commits into from
Apr 17, 2024

minor fixups after review

8162d43
Select commit
Loading
Failed to load commit list.
Merged

Gen4 Planner: support aggregate UDFs #15710

minor fixups after review
8162d43
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 17, 2024 in 1s

68.40% (-0.01%) compared to f118ba2

View this Pull Request on Codecov

68.40% (-0.01%) compared to f118ba2

Details

Codecov Report

Attention: Patch coverage is 93.28358% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 68.40%. Comparing base (f118ba2) to head (8162d43).
Report is 9 commits behind head on main.

Files Patch % Lines
...vt/vtgate/planbuilder/operators/queryprojection.go 86.66% 4 Missing ⚠️
go/vt/vtgate/vindexes/vschema.go 86.66% 2 Missing ⚠️
go/vt/vtgate/planbuilder/operators/aggregator.go 83.33% 1 Missing ⚠️
go/vt/vtgate/planbuilder/operators/hash_join.go 50.00% 1 Missing ⚠️
go/vt/wrangler/vexec_plan.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15710      +/-   ##
==========================================
- Coverage   68.40%   68.40%   -0.01%     
==========================================
  Files        1556     1556              
  Lines      195121   195393     +272     
==========================================
+ Hits       133479   133650     +171     
- Misses      61642    61743     +101

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov