-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split unit test and unit race into 2 components #15734
Conversation
…set of unit tests based on the environment variable Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Manan Gupta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15734 +/- ##
==========================================
+ Coverage 68.38% 68.40% +0.01%
==========================================
Files 1556 1556
Lines 195361 195418 +57
==========================================
+ Hits 133598 133666 +68
+ Misses 61763 61752 -11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the description to let people know how this affects make unit_test
?
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Description
This PR splits the
unit_test
andunit_race
workflows into 2 parts, one that runs the evalengine tests only, and the other that runs everything else. This has been done because the CI workflows started taking too long and necessicated splitting them up.The default behaviour of
make unit_test
andmake unit_race
doesn't change. In order to run restricted set of tests like we do in the CI,VTEVALENGINETEST
environment variable has to be set to"1"
or"-1"
.Related Issue(s)
Checklist
Deployment Notes