Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evalengine: Implement SEC_TO_TIME #15755

Merged
merged 7 commits into from
Apr 23, 2024

Make efficient use of decimal APIs

b9e929d
Select commit
Loading
Failed to load commit list.
Merged

evalengine: Implement SEC_TO_TIME #15755

Make efficient use of decimal APIs
b9e929d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 23, 2024 in 0s

68.43% (+0.04%) compared to 178e6e8

View this Pull Request on Codecov

68.43% (+0.04%) compared to 178e6e8

Details

Codecov Report

Attention: Patch coverage is 98.14815% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.43%. Comparing base (178e6e8) to head (b9e929d).
Report is 16 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/evalengine/fn_time.go 98.03% 1 Missing ⚠️
go/vt/vtgate/evalengine/translate_builtin.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15755      +/-   ##
==========================================
+ Coverage   68.38%   68.43%   +0.04%     
==========================================
  Files        1556     1556              
  Lines      195361   195598     +237     
==========================================
+ Hits       133598   133853     +255     
+ Misses      61763    61745      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.