Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ZooKeeper Topology connection locks not being cleaned up correctly #15757

Merged
merged 5 commits into from
Apr 20, 2024

Apply review suggestion

cfce401
Select commit
Loading
Failed to load commit list.
Merged

Fix ZooKeeper Topology connection locks not being cleaned up correctly #15757

Apply review suggestion
cfce401
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 19, 2024 in 0s

68.39% (-0.01%) compared to da1301b

View this Pull Request on Codecov

68.39% (-0.01%) compared to da1301b

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.39%. Comparing base (da1301b) to head (cfce401).
Report is 2 commits behind head on main.

Files Patch % Lines
go/vt/topo/zk2topo/lock.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15757      +/-   ##
==========================================
- Coverage   68.40%   68.39%   -0.01%     
==========================================
  Files        1556     1556              
  Lines      195418   195422       +4     
==========================================
- Hits       133666   133663       -3     
- Misses      61752    61759       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.