-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify error message when transaction not found in numbered pool #15760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harshit Gangal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Apr 19, 2024
harshit-gangal
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Apr 19, 2024
harshit-gangal
requested review from
systay,
shlomi-noach and
rohit-nayak-ps
as code owners
April 22, 2024 11:09
systay
approved these changes
Apr 22, 2024
harshit-gangal
force-pushed
the
tx-notfound
branch
from
April 23, 2024 07:39
e18421c
to
9036f59
Compare
rohit-nayak-ps
approved these changes
Apr 23, 2024
dbussink
approved these changes
Apr 23, 2024
Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
force-pushed
the
tx-notfound
branch
from
April 23, 2024 08:46
9036f59
to
e3d12dc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15760 +/- ##
==========================================
+ Coverage 68.38% 68.41% +0.02%
==========================================
Files 1556 1556
Lines 195361 195494 +133
==========================================
+ Hits 133598 133742 +144
+ Misses 61763 61752 -11 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modified the error message when a transaction ID is not found in the active pool and evicted from the unregisted cache. When there is a high QPS system, it can land in this situation. So, modified the message to give some potential reason for it i.e. a transaction timeout.
Related Issue(s)
Checklist
Deployment Notes