-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-tenant MoveTables: allow switching replica/rdonly traffic separately before switching primary traffic #15768
Multi-tenant MoveTables: allow switching replica/rdonly traffic separately before switching primary traffic #15768
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15768 +/- ##
==========================================
- Coverage 68.43% 68.41% -0.03%
==========================================
Files 1558 1558
Lines 196039 196093 +54
==========================================
- Hits 134161 134155 -6
- Misses 61878 61938 +60 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I only had some very minor comments/nits that you can address as you feel best.
mattlord's feedback still needs to be addressed. Rest LGTM. |
…ng rules Signed-off-by: Rohit Nayak <[email protected]>
…ly. Change expected keyspace routing rules. Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
…ules also for replica/rdonly Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
…, so you can't route target keyspace to a specific tenant Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
629d893
to
116a3b4
Compare
Signed-off-by: Rohit Nayak <[email protected]>
Description
As part of #15403 we had assumed it was fine to switch all traffic at the same time. However it turns out there are use cases where we may want to allow switching replica/rdonly and primary traffic separately, similar to other workflows.
This PR adds that support.
Related Issue(s)
#15403
Checklist