feat: Add support for Insert with row alias #15790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15790 +/- ##
==========================================
- Coverage 68.44% 68.44% -0.01%
==========================================
Files 1558 1558
Lines 195822 196129 +307
==========================================
+ Hits 134032 134233 +201
- Misses 61790 61896 +106 ☔ View full report in Codecov by Sentry. |
harshit-gangal
added
Type: Feature
Component: Query Serving
release notes (needs details)
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
removed
the
release notes (needs details)
harshit-gangal
requested review from
systay,
frouioui,
GuptaManan100,
arthurschreiber,
mattlord and
deepthi
as code owners
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
systay
reviewed
Apr 26, 2024
systay
approved these changes
Apr 26, 2024
Signed-off-by: Harshit Gangal <[email protected]>
GuptaManan100
approved these changes
Apr 29, 2024
Comment on lines
+369
to
+381
| // This is a check to ensure we send the correct query to the database. | ||
| // "ActualQuery" should not be part of the plan output, if it does, it means the query was not rewritten correctly. | ||
| if ins.Mid != nil { | ||
| var mids []string | ||
| for _, n := range ins.Mid { | ||
| mids = append(mids, sqlparser.String(n)) | ||
| } | ||
| shardedQuery := ins.Prefix + strings.Join(mids, ", ") + ins.Alias + sqlparser.String(ins.Suffix) | ||
| if shardedQuery != ins.Query { | ||
| other["ActualQuery"] = shardedQuery | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Was this code intended for debugging to see when the sharded query and the original query are different?
There was a problem hiding this comment.
I kept this for a reason to fail in future if anything goes wrong in the final query output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds planner support for new insert syntax
insert into t(id, col) values(1, 'apa') as dt(x) on duplicate key col = xRelated Issue(s)
Checklist
Deployment Notes