Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-19.0] Fix regression where inserts into reference tables with a different name on sharded keyspaces were not routed correctly. (#15796) #15860

Merged
merged 2 commits into from
May 8, 2024

Update statement is different from v20, hence needed to handle update…

3b613eb
Select commit
Loading
Failed to load commit list.
Merged

[release-19.0] Fix regression where inserts into reference tables with a different name on sharded keyspaces were not routed correctly. (#15796) #15860

Update statement is different from v20, hence needed to handle update…
3b613eb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 7, 2024 in 0s

67.47% (-0.01%) compared to 2c42825

View this Pull Request on Codecov

67.47% (-0.01%) compared to 2c42825

Details

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 67.47%. Comparing base (2c42825) to head (3b613eb).

Files Patch % Lines
.../vt/vtgate/planbuilder/operators/route_planning.go 77.77% 2 Missing ⚠️
go/vt/vtgate/planbuilder/operators/update.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #15860      +/-   ##
================================================
- Coverage         67.47%   67.47%   -0.01%     
================================================
  Files              1560     1560              
  Lines            192780   192794      +14     
================================================
+ Hits             130076   130084       +8     
- Misses            62704    62710       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.