-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the default for replica-net-timeout #15938
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this ended up being a problem? #15663 (review) Or it was something else?
@mattlord Yes exactly! It was exactly that, if we restart a running mysql instance with the new my.cnf then the replica_net_timeout value gets changed, but the hearbeat_interval does not. |
Description
As described in #15937 (comment), this PR needs to revert the changes in #15663 and #15689. We'll reintroduce the default change in next release.
Related Issue(s)
replica_net_timeout
can cause issues while upgrading #15937Checklist
Deployment Notes