Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for vtgate traffic mirroring #15945

Merged
merged 9 commits into from
Jul 1, 2024

Merge branch 'main' into maxeng-mirror-routingrules

91a75e4
Select commit
Loading
Failed to load commit list.
Merged

add support for vtgate traffic mirroring #15945

Merge branch 'main' into maxeng-mirror-routingrules
91a75e4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 28, 2024 in 0s

68.70% (-0.02%) compared to bb76046

View this Pull Request on Codecov

68.70% (-0.02%) compared to bb76046

Details

Codecov Report

Attention: Patch coverage is 60.90535% with 95 lines in your changes missing coverage. Please review.

Project coverage is 68.70%. Comparing base (bb76046) to head (91a75e4).

Files Patch % Lines
...lient/command/vreplication/common/mirrortraffic.go 24.39% 31 Missing ⚠️
go/vt/vtctl/grpcvtctldserver/server.go 5.00% 19 Missing ⚠️
go/cmd/vtctldclient/command/mirror_rules.go 16.66% 10 Missing ⚠️
go/vt/vtctl/grpcvtctldclient/client_gen.go 0.00% 8 Missing ⚠️
go/vt/vtctl/workflow/server.go 88.33% 7 Missing ⚠️
go/vt/vtcombo/tablet_map.go 0.00% 6 Missing ⚠️
go/vt/vtctl/localvtctldclient/client_gen.go 0.00% 4 Missing ⚠️
go/vt/topo/vschema.go 85.71% 3 Missing ⚠️
go/vt/vtctl/workflow/traffic_switcher.go 88.46% 3 Missing ⚠️
go/cmd/vtcombo/cli/main.go 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15945      +/-   ##
==========================================
- Coverage   68.71%   68.70%   -0.02%     
==========================================
  Files        1544     1547       +3     
  Lines      198011   198247     +236     
==========================================
+ Hits       136064   136200     +136     
- Misses      61947    62047     +100

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov