-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
messager: add consistent log prefix w/ table name #15973
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
ded1edc
to
1c1e408
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15973 +/- ##
==========================================
+ Coverage 68.45% 68.54% +0.09%
==========================================
Files 1562 1562
Lines 197057 197599 +542
==========================================
+ Hits 134891 135446 +555
+ Misses 62166 62153 -13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! Thank you, @derekperkins ! I just had a couple of very minor comments. I can come back quickly and help get this merged.
Signed-off-by: Derek Perkins <[email protected]>
1c1e408
to
bb000f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ❤️
Description
We've been seeing some message related errors, but without the table name, it's hard to figure out what's going on. This also adds a consistent prefix that was already in use for many of the logging calls, but not all of them.
Checklist