Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connpool: Allow time out during shutdown #15979

Merged
merged 8 commits into from
May 23, 2024

tabletserver: pass ctx when changing pool size

80a6995
Select commit
Loading
Failed to load commit list.
Merged

connpool: Allow time out during shutdown #15979

tabletserver: pass ctx when changing pool size
80a6995
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 22, 2024 in 0s

68.47% (+0.01%) compared to 8b60b59

View this Pull Request on Codecov

68.47% (+0.01%) compared to 8b60b59

Details

Codecov Report

Attention: Patch coverage is 72.72727% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 68.47%. Comparing base (8b60b59) to head (80a6995).
Report is 7 commits behind head on main.

Files Patch % Lines
go/vt/vttablet/tabletserver/debugenv.go 0.00% 11 Missing ⚠️
go/pools/smartconnpool/pool.go 91.42% 3 Missing ⚠️
go/vt/vttablet/tabletserver/tabletserver.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15979      +/-   ##
==========================================
+ Coverage   68.46%   68.47%   +0.01%     
==========================================
  Files        1562     1562              
  Lines      197059   197100      +41     
==========================================
+ Hits       134919   134972      +53     
+ Misses      62140    62128      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.