-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication: Remove noisy logs #15987
VReplication: Remove noisy logs #15987
Conversation
Signed-off-by: Rohit Nayak <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15987 +/- ##
==========================================
+ Coverage 68.45% 68.47% +0.02%
==========================================
Files 1562 1562
Lines 197057 197079 +22
==========================================
+ Hits 134891 134953 +62
+ Misses 62166 62126 -40 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I actually noticed this noisy logging recently as well when doing local testing on #15797
Description
It has been reported that some logs around the
LastError
module were spamming the consolidated logs when streaming from a large cluster (say 256 shards). This PR removes the noisy log lines and which don't add much value.Related Issue(s)
Checklist
Deployment Notes