Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology Server Locking Refactor #16005

Merged
merged 11 commits into from
Jun 12, 2024

feat: address review comments

febce16
Select commit
Loading
Failed to load commit list.
Merged

Topology Server Locking Refactor #16005

feat: address review comments
febce16
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 30, 2024 in 0s

68.23% (-0.01%) compared to a1edaee, passed because coverage increased by +0.00% when compared to adjusted base (68.22%)

View this Pull Request on Codecov

68.23% (-0.01%) compared to a1edaee, passed because coverage increased by +0.00% when compared to adjusted base (68.22%)

Details

Codecov Report

Attention: Patch coverage is 96.05263% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 68.23%. Comparing base (a1edaee) to head (febce16).
Report is 14 commits behind head on main.

Files Patch % Lines
go/vt/topo/locks.go 89.28% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16005      +/-   ##
==========================================
- Coverage   68.24%   68.23%   -0.01%     
==========================================
  Files        1562     1542      -20     
  Lines      197171   196969     -202     
==========================================
- Hits       134550   134394     -156     
+ Misses      62621    62575      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.