-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert the removal of the MySQL binaries in the vitess/lite
image
#16042
Conversation
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
docker/lite/Dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Symlink was broken on main for some time
@@ -7,7 +7,6 @@ | |||
- **[Deletions](#deletions)** | |||
- [`--vreplication_tablet_type` flag](#vreplication-tablet-type-deletion) | |||
- [Pool Capacity Flags](#pool-flags-deletion) | |||
- [MySQL binaries in the vitess/lite Docker images](#vitess-lite) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the v19.0.0
release notes we say the following:
The
mysqld
binary is now deprecated in thevitess/lite
Docker image and will be removed in a future release.
Thus, other than removing the release notes we added in v20
I don't think there is anything else needed here.
We are removing the mysql-57
and percona-57
images but that's a side effect of dropping support for 5.7 in v19
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16042 +/- ##
=======================================
Coverage 68.23% 68.23%
=======================================
Files 1541 1541
Lines 197254 197254
=======================================
Hits 134597 134597
Misses 62657 62657 ☔ View full report in Codecov by Sentry. |
DCO is down, so I have manually verified that commits |
Forced merge this using |
Description
We have been facing multiple issues after we merged #15620. Mainly, the
xtrabackup
andmysqlbinlog
binaries were missing and thus we could not use certain features of vitess. There was several attempts to fix this: #15775 and #15854, which both failed. We have a plan internally on how to make this work, but as of today (1 day before the code freeze of v20) I have not been able to make that plan work, hence the revert.