Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-20.0] Changelog 20.0: Fix broken links (#16048) #16076

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jun 6, 2024

Description

This is a backport of #16048

@vitess-bot vitess-bot bot requested a review from deepthi as a code owner June 6, 2024 14:09
@vitess-bot vitess-bot bot added Backport This is a backport Component: Documentation docs related issues/PRs Type: Documentation labels Jun 6, 2024
@vitess-bot vitess-bot bot requested a review from shlomi-noach June 6, 2024 14:09
Copy link
Contributor Author

vitess-bot bot commented Jun 6, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@shlomi-noach shlomi-noach requested a review from a team June 6, 2024 14:09
@github-actions github-actions bot added this to the v20.0.0 milestone Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.22%. Comparing base (83c14fa) to head (c053441).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #16076      +/-   ##
================================================
+ Coverage         68.20%   68.22%   +0.02%     
================================================
  Files              1541     1541              
  Lines            197330   197330              
================================================
+ Hits             134591   134632      +41     
+ Misses            62739    62698      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shlomi-noach shlomi-noach merged commit be83207 into release-20.0 Jun 9, 2024
186 of 187 checks passed
@shlomi-noach shlomi-noach deleted the backport-16048-to-release-20.0 branch June 9, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport This is a backport Component: Documentation docs related issues/PRs Type: Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants