Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing support for ANY/SOME/ALL comparison modifiers. #16080

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

arthurschreiber
Copy link
Contributor

@arthurschreiber arthurschreiber commented Jun 7, 2024

Description

This PR introduces support for the ANY and ALL operators in subqueries within the Vitess SQL parser.
For the time being, it's only supported when the query can be merged into a single query that is passed down to MySQL.

Example Usage

SELECT *
FROM employees
WHERE salary > ANY (SELECT salary FROM interns);

SELECT *
FROM employees
WHERE salary > ALL (SELECT salary FROM interns);

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Jun 7, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 7, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jun 7, 2024
@arthurschreiber
Copy link
Contributor Author

arthurschreiber commented Jun 7, 2024

Note: This currently allows using the ANY/SOME/ALL modifiers in combination with the null safe comparison operator (<=>) which is not actually allowed by MySQL.

Output provided by @systay:

mysql> select * from foo where b <=> any (select id from t1);
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '<=> any (select id from t1)' at line 1

This should probably be fixed so our parser matches MySQL's parser more closely.

@systay systay added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jun 7, 2024
Signed-off-by: Andres Taylor <[email protected]>
@systay systay force-pushed the arthur/any-all-some branch from a9df36a to a651297 Compare June 7, 2024 08:28
@systay

This comment was marked as resolved.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.26%. Comparing base (87ecae7) to head (c5ed057).
Report is 2 commits behind head on main.

Files Patch % Lines
go/vt/sqlparser/ast_format.go 66.66% 2 Missing ⚠️
go/vt/vtgate/semantics/analyzer.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16080      +/-   ##
==========================================
+ Coverage   68.19%   68.26%   +0.06%     
==========================================
  Files        1541     1544       +3     
  Lines      197369   197737     +368     
==========================================
+ Hits       134605   134994     +389     
+ Misses      62764    62743      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

systay and others added 2 commits June 10, 2024 11:44
@GuptaManan100
Copy link
Member

I have pushed a fix now for the parser conflicts. I've also made the parser fail for queries that have null safe equality with a column modifier! 💕

@systay systay marked this pull request as ready for review June 10, 2024 10:57
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arthurschreiber arthurschreiber merged commit dbb8863 into main Jun 11, 2024
184 checks passed
@arthurschreiber arthurschreiber deleted the arthur/any-all-some branch June 11, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants