-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parsing support for ANY
/SOME
/ALL
comparison modifiers.
#16080
Conversation
Signed-off-by: Arthur Schreiber <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Note: This currently allows using the Output provided by @systay:
This should probably be fixed so our parser matches MySQL's parser more closely. |
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
a9df36a
to
a651297
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16080 +/- ##
==========================================
+ Coverage 68.19% 68.26% +0.06%
==========================================
Files 1541 1544 +3
Lines 197369 197737 +368
==========================================
+ Hits 134605 134994 +389
+ Misses 62764 62743 -21 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andres Taylor <[email protected]>
…mparison with column modifiers Signed-off-by: Manan Gupta <[email protected]>
I have pushed a fix now for the parser conflicts. I've also made the parser fail for queries that have null safe equality with a column modifier! 💕 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR introduces support for the
ANY
andALL
operators in subqueries within the Vitess SQL parser.For the time being, it's only supported when the query can be merged into a single query that is passed down to MySQL.
Example Usage
Related Issue(s)
Checklist