-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Bug: Rename shard name back to match existing workflow file for vreplication_migrate_vdiff2_convert_tz #16148
Merged
GuptaManan100
merged 3 commits into
vitessio:main
from
planetscale:rohit/ci-workflow-fix
Jun 13, 2024
Merged
CI Bug: Rename shard name back to match existing workflow file for vreplication_migrate_vdiff2_convert_tz #16148
GuptaManan100
merged 3 commits into
vitessio:main
from
planetscale:rohit/ci-workflow-fix
Jun 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jun 13, 2024
rohit-nayak-ps
added
Backport to: release-20.0
Needs to be backport to release-20.0
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Jun 13, 2024
rohit-nayak-ps
requested review from
GuptaManan100,
frouioui,
deepthi,
mattlord and
harshit-gangal
as code owners
June 13, 2024 08:02
Signed-off-by: Rohit Nayak <[email protected]>
dbussink
approved these changes
Jun 13, 2024
GuptaManan100
approved these changes
Jun 13, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
…eplication_migrate_vdiff2_convert_tz (#16148) Signed-off-by: Rohit Nayak <[email protected]>
rohit-nayak-ps
pushed a commit
that referenced
this pull request
Jun 13, 2024
…low file for vreplication_migrate_vdiff2_convert_tz (#16148) (#16151) Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-20.0
Needs to be backport to release-20.0
Component: Build/CI
Component: VReplication
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes two changes:
The shard name
vreplication_migrate_vdiff2_convert_tz
was changed in PR VReplication: Fix vtctldclient SwitchReads related bugs and move the TestBasicV2Workflows e2e test to vtctldclient #15579 but the workflow file was not renamed. Hence the related tests are no longer running in CI. This PR changes it back, so we can continue to use the same workflow name to avoid having to update the list of Required actions ...Cluster 22 was no longer necessary after Delete all legacy sharding related code #10278. Deleted that shard and removed the workflow from the Required set in the GitHub Repo Settings.
Related Issue(s)
#15579
#10278
Checklist
Deployment Notes