-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI flaky test: Fix flakiness in vreplication_migrate_vdiff2_convert_tz #16180
CI flaky test: Fix flakiness in vreplication_migrate_vdiff2_convert_tz #16180
Conversation
…ors. Comment flaky vdiff stop test Signed-off-by: Rohit Nayak <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @rohit-nayak-ps ! ❤️ I'll re-run the workflow a few times and then, assuming it passes each time, go ahead and merge it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16180 +/- ##
==========================================
+ Coverage 68.54% 68.58% +0.03%
==========================================
Files 1544 1544
Lines 197737 197750 +13
==========================================
+ Hits 135532 135620 +88
+ Misses 62205 62130 -75 ☔ View full report in Codecov by Sentry. |
#16180) Signed-off-by: Rohit Nayak <[email protected]> Signed-off-by: Matt Lord <[email protected]> Co-authored-by: Matt Lord <[email protected]>
…diff2_convert_tz (#16180) (#16189) Signed-off-by: Rohit Nayak <[email protected]> Signed-off-by: Matt Lord <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <[email protected]>
Description
Fixes two flaky tests:
Address the
VDiff stop
test which also regularly fails locally. The problem here is that we are trying to stop a vdiff which completes before it can be stopped.vtctldclient
is generally much faster and we have virtually no data to diff so there's not really any way to avoid this race. So we considerstopped
andcompleted
to be valid/acceptable.Fixes
TestVtctldMigrate
e2e test.After VReplication: Improve workflow cancel/delete #15977 the target also has denied tables and hence we need to query the tablets directly rather than check via vtgate.
Related Issue(s)
Checklist
Deployment Notes