Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release notes: update dml related release notes #16241

Merged
merged 1 commit into from
Jun 21, 2024
Merged

release notes: update dml related release notes #16241

merged 1 commit into from
Jun 21, 2024

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Jun 20, 2024 •
edited
Loading

Description

Updating v20-related release notes for clarity.
Adding backport label as well to keep in sync.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description

@harshit-gangal harshit-gangal requested a review from deepthi as a code owner June 20, 2024 16:35
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jun 20, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 20, 2024
@harshit-gangal harshit-gangal added Type: Documentation Component: General Changes throughout the code base Backport to: release-20.0-rc Backport to: release-20.0 Needs to be backport to release-20.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jun 20, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jun 20, 2024
@derekperkins
Copy link
Member

Thanks for the clarifications. Did you say that it doesn't always perform select + update if the query planner determines it's a single shard update, in which case the update is sent as is?

@harshit-gangal
Copy link
Member Author

Thanks for the clarifications. Did you say that it doesn't always perform select + update if the query planner determines it's a single shard update, in which case the update is sent as is?

That part is given, it applies to anything we do in the planner.

@harshit-gangal harshit-gangal merged commit 6c7fed9 into vitessio:main Jun 21, 2024
106 checks passed
@harshit-gangal harshit-gangal deleted the changelog-update branch June 21, 2024 16:01
vitess-bot pushed a commit that referenced this pull request Jun 21, 2024
@vitess-bot
release notes: update dml related release notes (#16241)
855477c 
Signed-off-by: Harshit Gangal <[email protected]>
@vitess-bot vitess-bot bot mentioned this pull request Jun 21, 2024
Merged
vitess-bot pushed a commit that referenced this pull request Jun 21, 2024
@vitess-bot
release notes: update dml related release notes (#16241)
8efa977 
Signed-off-by: Harshit Gangal <[email protected]>
@vitess-bot vitess-bot bot mentioned this pull request Jun 21, 2024
Merged
frouioui pushed a commit that referenced this pull request Jun 21, 2024
@vitess-bot
[release-20.0] release notes: update dml related release notes (#16241)…
54c4abe 
… (#16247)

Signed-off-by: Harshit Gangal <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
shlomi-noach pushed a commit that referenced this pull request Jun 25, 2024
@vitess-bot
[release-20.0-rc] release notes: update dml related release notes (#1…
eef7761 
…6241) (#16246)

Signed-off-by: Harshit Gangal <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlord mattlord mattlord approved these changes

@systay systay systay approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach

@frouioui frouioui Awaiting requested review from frouioui

@derekperkins derekperkins Awaiting requested review from derekperkins

Assignees
No one assigned
Labels
Backport to: release-20.0 Needs to be backport to release-20.0 Component: General Changes throughout the code base Type: Documentation
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@harshit-gangal @derekperkins @systay @mattlord