Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new mysql shell backup engine #16295

Merged
merged 44 commits into from
Sep 24, 2024

add missing grant

bc2cff2
Select commit
Loading
Failed to load commit list.
Merged

adding new mysql shell backup engine #16295

add missing grant
bc2cff2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 24, 2024 in 0s

69.43% (-0.08%) compared to 6d43afc

View this Pull Request on Codecov

69.43% (-0.08%) compared to 6d43afc

Details

Codecov Report

Attention: Patch coverage is 25.07740% with 242 lines in your changes missing coverage. Please review.

Project coverage is 69.43%. Comparing base (6d43afc) to head (bc2cff2).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/mysqlctl/mysqlshellbackupengine.go 24.10% 211 Missing ⚠️
go/vt/mysqlctl/query.go 0.00% 21 Missing ⚠️
go/vt/mysqlctl/fakemysqldaemon.go 33.33% 4 Missing ⚠️
go/vt/mysqlctl/backup.go 83.33% 2 Missing ⚠️
go/vt/mysqlctl/builtinbackupengine.go 0.00% 2 Missing ⚠️
go/vt/mysqlctl/xtrabackupengine.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16295      +/-   ##
==========================================
- Coverage   69.51%   69.43%   -0.08%     
==========================================
  Files        1569     1570       +1     
  Lines      202529   202945     +416     
==========================================
+ Hits       140784   140913     +129     
- Misses      61745    62032     +287

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov