Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-20.0] Upgrade the Golang version to go1.22.6 #16546

Merged
merged 8 commits into from
Aug 20, 2024

Conversation

vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot commented Aug 7, 2024

This Pull Request bumps the Golang version to go1.22.6 and the bootstrap version to 32.2.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

There are a few manual steps remaining:

  • Make sure you update the Golang version used in the previous and next release branches for the Upgrade/Downgrade tests.
  • Build and Push the bootstrap images to Docker Hub, the bot cannot handle that.
  • Update the ./.github/workflows/*.yml files with the newer Golang version, the bot cannot handle that due to permissions.
    • To accomplish this, run the following: go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.22.6

cc @vitessio/release

@vitess-bot vitess-bot added Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go Skip CI Skip CI actions from running Type: CI/Build labels Aug 7, 2024
@vitess-bot vitess-bot requested a review from a team August 7, 2024 00:25
Copy link
Contributor

vitess-bot bot commented Aug 7, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

Copy link
Contributor

vitess-bot bot commented Aug 7, 2024

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Aug 7, 2024
@github-actions github-actions bot added this to the v20.0.2 milestone Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.71%. Comparing base (4c8bff1) to head (d452817).
Report is 6 commits behind head on release-20.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #16546      +/-   ##
================================================
+ Coverage         68.65%   68.71%   +0.05%     
================================================
  Files              1541     1541              
  Lines            197864   199269    +1405     
================================================
+ Hits             135850   136934    +1084     
- Misses            62014    62335     +321     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says Skip CI Skip CI actions from running labels Aug 7, 2024
@shlomi-noach shlomi-noach removed NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Aug 7, 2024
shlomi-noach and others added 4 commits August 7, 2024 12:53
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui force-pushed the upgrade-go-to-1.22.6-on-release-20.0 branch from 38a0b91 to d452817 Compare August 14, 2024 19:39
Comment on lines +19 to +20
apt-get update -y && apt-get install -y percona-release && \
percona-release enable-only tools && apt-get update -y && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix required to install percona.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v20 does not support 5.7 any more, does it? Can't we delete this and the percona57 version?

Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the 5.7 docker files being deleted in a separate PR.

@frouioui frouioui merged commit bc754b9 into release-20.0 Aug 20, 2024
289 of 367 checks passed
@frouioui frouioui deleted the upgrade-go-to-1.22.6-on-release-20.0 branch August 20, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go Type: CI/Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants