-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-20.0] Upgrade the Golang version to go1.22.6
#16546
Conversation
Signed-off-by: GitHub <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Hello! 👋 This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked. You can find the performance comparison on the arewefastyet website. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-20.0 #16546 +/- ##
================================================
+ Coverage 68.65% 68.71% +0.05%
================================================
Files 1541 1541
Lines 197864 199269 +1405
================================================
+ Hits 135850 136934 +1084
- Misses 62014 62335 +321 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
38a0b91
to
d452817
Compare
apt-get update -y && apt-get install -y percona-release && \ | ||
percona-release enable-only tools && apt-get update -y && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix required to install percona.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v20 does not support 5.7 any more, does it? Can't we delete this and the percona57 version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with the 5.7 docker files being deleted in a separate PR.
This Pull Request bumps the Golang version to
go1.22.6
and the bootstrap version to32.2
.There are a few manual steps remaining:
./.github/workflows/*.yml
files with the newer Golang version, the bot cannot handle that due to permissions.go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.22.6
cc @vitessio/release