-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication: Add custom logger support to Workflow Server #16547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a feature of the Wrangler -- which the Workflow Server is replacing -- to Workflow Server. Signed-off-by: Matt Lord <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Aug 7, 2024
Signed-off-by: Matt Lord <[email protected]>
mattlord
removed
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
labels
Aug 7, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16547 +/- ##
=======================================
Coverage 68.82% 68.82%
=======================================
Files 1557 1558 +1
Lines 200007 200025 +18
=======================================
+ Hits 137648 137677 +29
+ Misses 62359 62348 -11 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
ws_logger
branch
2 times, most recently
from
August 7, 2024 23:06
98e4050
to
e5eaeb6
Compare
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
mattlord
requested review from
ajm188,
deepthi and
rohit-nayak-ps
as code owners
August 8, 2024 22:37
rohit-nayak-ps
approved these changes
Aug 13, 2024
Signed-off-by: Matt Lord <[email protected]>
shlomi-noach
approved these changes
Aug 15, 2024
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bit of internal cleanup done as part of transitioning to the new client and its associated packages.
This closes a feature gap between the clients' internal packages by adding a feature of the wrangler package to the workflow package which it was heretofor missing — with the workflow package replacing the wrangler package in the client transition.
Related Issue(s)
Checklist