Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Add custom logger support to Workflow Server #16547

Merged
merged 9 commits into from
Aug 15, 2024

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Aug 7, 2024

Description

This is a bit of internal cleanup done as part of transitioning to the new client and its associated packages.

This closes a feature gap between the clients' internal packages by adding a feature of the wrangler package to the workflow package which it was heretofor missing — with the workflow package replacing the wrangler package in the client transition.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

This adds a feature of the Wrangler -- which the Workflow Server
is replacing -- to Workflow Server.

Signed-off-by: Matt Lord <[email protected]>
Copy link
Contributor

vitess-bot bot commented Aug 7, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Aug 7, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Aug 7, 2024
@mattlord mattlord removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work labels Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 40.42553% with 56 lines in your changes missing coverage. Please review.

Project coverage is 68.82%. Comparing base (95c77e9) to head (854526d).
Report is 1 commits behind head on main.

Files Patch % Lines
go/vt/vtctl/workflow/server.go 48.33% 31 Missing ⚠️
go/vt/vtctl/workflow/traffic_switcher.go 34.78% 15 Missing ⚠️
go/vt/vtctl/workflow/server_options.go 0.00% 9 Missing ⚠️
go/vt/vtctl/workflow/utils.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16547   +/-   ##
=======================================
  Coverage   68.82%   68.82%           
=======================================
  Files        1557     1558    +1     
  Lines      200007   200025   +18     
=======================================
+ Hits       137648   137677   +29     
+ Misses      62359    62348   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattlord mattlord force-pushed the ws_logger branch 2 times, most recently from 98e4050 to e5eaeb6 Compare August 7, 2024 23:06
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord marked this pull request as ready for review August 8, 2024 22:37
@mattlord mattlord requested a review from maxenglander August 9, 2024 16:45
@mattlord mattlord requested a review from a team August 15, 2024 13:39
@mattlord mattlord merged commit 127b9ae into vitessio:main Aug 15, 2024
129 checks passed
@mattlord mattlord deleted the ws_logger branch August 15, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants