-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Planner cleaning: cleanup and refactor #16569
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16569 +/- ##
==========================================
- Coverage 68.85% 68.83% -0.03%
==========================================
Files 1557 1557
Lines 199891 199983 +92
==========================================
+ Hits 137644 137659 +15
- Misses 62247 62324 +77 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Signed-off-by: Andres Taylor <[email protected]>
Description
While working on #16427, I've stumbled across quite a few annoyances in the code that needed fixing before we could finish the CTE work. Instead of making that PR even bigger, I'm extracting all the clean ups into this PR.
The kind of clean ups are:
AddWSColumn
instead ofAddColumn
to addweight_strings
.Related Issue(s)
Checklist
Deployment Notes