Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Improve table plan builder errors #16588

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Aug 13, 2024

Description

This is a quick bit of internal cleanup that improves the table plan builder's error messages so that they contain the table name. This is pretty important when a workflow is operating on thousands of tables.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Signed-off-by: Matt Lord <[email protected]>
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@f2d5d1c). Learn more about missing BASE report.

Files Patch % Lines
...t/tabletmanager/vreplication/table_plan_builder.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16588   +/-   ##
=======================================
  Coverage        ?   68.79%           
=======================================
  Files           ?     1557           
  Lines           ?   199891           
  Branches        ?        0           
=======================================
  Hits            ?   137521           
  Misses          ?    62370           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattlord mattlord requested a review from a team August 13, 2024 13:02
@mattlord mattlord merged commit 61959f6 into main Aug 13, 2024
221 checks passed
@mattlord mattlord deleted the table_plan_errors branch August 13, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants