Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online DDL: new message_timestamp column in schema_migrations table #16633

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

shlomi-noach
Copy link
Contributor

Description

This PR introduces schema_migrations. message_timestamp column, which gets updated to current timestamp whenever message gets updated.

The column gets auto-populated with the same query that updates the message. There is thus no actual code change other than an SQL.

Related Issue(s)

Fixes #16632

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) labels Aug 22, 2024
Copy link
Contributor

vitess-bot bot commented Aug 22, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Aug 22, 2024
@shlomi-noach shlomi-noach requested a review from a team August 22, 2024 10:31
@shlomi-noach shlomi-noach changed the title Online DDL: new 'message_timestamp' column in 'schema_migrations' table Online DDL: new message_timestamp column in schema_migrations table Aug 22, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Aug 22, 2024
@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.98%. Comparing base (538dd4c) to head (3ca1142).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16633      +/-   ##
==========================================
- Coverage   68.98%   68.98%   -0.01%     
==========================================
  Files        1562     1562              
  Lines      200690   200690              
==========================================
- Hits       138449   138436      -13     
- Misses      62241    62254      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -42,6 +42,7 @@ CREATE TABLE IF NOT EXISTS schema_migrations
`migration_context` varchar(1024) NOT NULL DEFAULT '',
`ddl_action` varchar(16) NOT NULL DEFAULT '',
`message` text NOT NULL,
`message_timestamp` timestamp(6) NULL DEFAULT NULL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why timestamp(6) and not a normal timestamp like other columns?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Practice tells me that I always end up "upgrading" a timetstamp to timestamp(6). I just appreciate the granularity, especially when it comes to critical points such as cutover where it can really clarify what's going on.

@shlomi-noach shlomi-noach merged commit eb11918 into vitessio:main Aug 25, 2024
138 of 141 checks passed
@shlomi-noach shlomi-noach deleted the onlineddl-message-timestamp branch August 25, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Online DDL, indicate when a message was updated in schema_migrations.
3 participants