JSON Encoding: Use Type_RAW for marshalling json

[rohit-nayak-ps]

Description

This PR cherry-picks commits from #16615, but reverts the changes made in insert_select.go to treat Type_JSON differently, but uses all the added tests. #16615 is an attempt to fix the issue #16614 with sending json type as bind variable to vttablet.

This PR attempts to fix that issue by not sending the marshalled json objects in vreplication workflows as a newly introduced internal type Type_RAW which is encoded as raw bytes. Previously we used to encode Type_JSON as raw, which is incorrect since we do want to quote json strings. In vreplication workflows, we use json functions like json_object() to specify the json document to preserve precision of large integers.

This bug is present since several versions, so we backport to all supported versions.

Marked Do Not Merge while waiting for more 👀 on this change.

Related Issue(s)

• Fixes Bug Report: syntax error while trying to use INSERT INTO ... SELECT * FROM ... to copy data between keyspaces #16614

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.92%. Comparing base (feb845a) to head (223efa6).
Report is 32 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16637      +/-   ##
==========================================
- Coverage   68.98%   68.92%   -0.06%     
==========================================
  Files        1562     1564       +2     
  Lines      200697   201371     +674     
==========================================
+ Hits       138446   138798     +352     
- Misses      62251    62573     +322     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[harshit-gangal]

Changes looks good to me