-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TabletServer: execute DDLs without timeout #16711
Conversation
Signed-off-by: Shlomi Noach <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16711 +/- ##
==========================================
- Coverage 68.93% 68.92% -0.01%
==========================================
Files 1565 1565
Lines 201682 201684 +2
==========================================
- Hits 139020 139002 -18
- Misses 62662 62682 +20 ☔ View full report in Codecov by Sentry. |
The way to run long-running DDLs is through ApplySchema. query-timeout at tablet level is supposed to apply to everything. @harshit-gangal will come back with an alternate proposal to solving this feature request. |
Closing in favor of #16735 |
Description
See description in #16710
The implementation is:
Plan
PlanDDL
context.WithTimeout()
) with acontext.WithoutTimeout()
(new ingo1.21
).Seeking advice on how to test this.
Related Issue(s)
Fixes #16710
Checklist
Deployment Notes