-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BinlogEvent
: publish ServerID()
function
#16713
Merged
shlomi-noach
merged 2 commits into
vitessio:main
from
planetscale:binlog-event-server-id
Sep 15, 2024
Merged
BinlogEvent
: publish ServerID()
function
#16713
shlomi-noach
merged 2 commits into
vitessio:main
from
planetscale:binlog-event-server-id
Sep 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Query Serving
labels
Sep 5, 2024
shlomi-noach
requested review from
harshit-gangal,
systay and
mattlord
as code owners
September 5, 2024 05:47
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Sep 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16713 +/- ##
==========================================
+ Coverage 68.93% 68.95% +0.01%
==========================================
Files 1565 1565
Lines 201745 201747 +2
==========================================
+ Hits 139075 139105 +30
+ Misses 62670 62642 -28 ☔ View full report in Codecov by Sentry. |
shlomi-noach
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Sep 5, 2024
Signed-off-by: Shlomi Noach <[email protected]>
mattlord
approved these changes
Sep 10, 2024
rohit-nayak-ps
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Query Serving
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MySQL binlog protocol: for completeness and consistency, we add the
ServerID()
function inBinlogEvent
. The function is already implemented and tested in the implementingbinlogEvent
type, but was never made public in the interface.Related Issue(s)
none
Checklist
Deployment Notes