-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: authoritative query timeout for vttablet from vtgate #16735
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f598f70
feat: add query timeout to execute options to proto
harshit-gangal 5a693ff
feat: use authoritative timeout from execute options if provided
harshit-gangal 4451119
feat: set query timeout on execute options and refactor query hints
harshit-gangal 7e01664
take query timeout set at session into account
harshit-gangal 0ef24ab
fix: timeout in milliseconds
harshit-gangal bb03bc9
feat: set query timeout on query execution at vtgate
harshit-gangal 061c1f0
added test to tablet changes
harshit-gangal 5e1ec56
fix: context cancel call
harshit-gangal af6de49
removed all leaf level context timeout setting for non-streaming
harshit-gangal e061353
test: added e2e test
harshit-gangal d8ba52b
test: added unit test
harshit-gangal 71aa779
addressed review comment
harshit-gangal 118e246
move cancel func to other variable declaration
harshit-gangal 0637b82
Merge remote-tracking branch 'upstream/main' into query-timeout
harshit-gangal a857a5e
added release notes
harshit-gangal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even one of them set is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
is
is more apt here.