Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the results observer easier to extend, and give it a life cycle #16736

Closed
wants to merge 2 commits into from

change interface of resultObserver

be19f48
Select commit
Loading
Failed to load commit list.
Closed

make the results observer easier to extend, and give it a life cycle #16736

change interface of resultObserver
be19f48
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 10, 2024 in 1s

68.93% (-0.01%) compared to a513601, passed because coverage increased by -0.01% when compared to adjusted base (68.93%)

View this Pull Request on Codecov

68.93% (-0.01%) compared to a513601, passed because coverage increased by -0.01% when compared to adjusted base (68.93%)

Details

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.93%. Comparing base (a513601) to head (be19f48).

Files with missing lines Patch % Lines
go/vt/vtgate/vcursor_impl.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16736      +/-   ##
==========================================
- Coverage   68.93%   68.93%   -0.01%     
==========================================
  Files        1565     1565              
  Lines      201745   201749       +4     
==========================================
- Hits       139075   139073       -2     
- Misses      62670    62676       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.