Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Validate min set of user permissions in traffic switch prechecks #16762

Merged
merged 22 commits into from
Sep 24, 2024

Tiny nits from final self review

648157c
Select commit
Loading
Failed to load commit list.
Merged

VReplication: Validate min set of user permissions in traffic switch prechecks #16762

Tiny nits from final self review
648157c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 24, 2024 in 0s

69.49% (-0.02%) compared to 95f2e3e

View this Pull Request on Codecov

69.49% (-0.02%) compared to 95f2e3e

Details

Codecov Report

Attention: Patch coverage is 10.97561% with 73 lines in your changes missing coverage. Please review.

Project coverage is 69.49%. Comparing base (95f2e3e) to head (648157c).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/tabletmanager/rpc_vreplication.go 0.00% 26 Missing ⚠️
go/vt/vtctl/workflow/server.go 27.27% 24 Missing ⚠️
go/vt/vttablet/grpctmclient/client.go 0.00% 9 Missing ⚠️
go/vt/vttablet/grpctmserver/server.go 0.00% 6 Missing ⚠️
go/vt/vtcombo/tablet_map.go 0.00% 2 Missing ⚠️
go/vt/vtctl/workflow/utils.go 0.00% 2 Missing ⚠️
go/vt/vttablet/faketmclient/fake_client.go 0.00% 2 Missing ⚠️
go/vt/vttablet/tmrpctest/test_tm_rpc.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16762      +/-   ##
==========================================
- Coverage   69.51%   69.49%   -0.02%     
==========================================
  Files        1569     1569              
  Lines      202517   202633     +116     
==========================================
+ Hits       140780   140827      +47     
- Misses      61737    61806      +69

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov