Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail fast when builtinbackup fails to restore a single file #16856

Merged
merged 5 commits into from
Sep 30, 2024

Review suggestion

a107193
Select commit
Loading
Failed to load commit list.
Merged

Fail fast when builtinbackup fails to restore a single file #16856

Review suggestion
a107193
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 30, 2024 in 0s

69.45% (+0.01%) compared to 2e2b223

View this Pull Request on Codecov

69.45% (+0.01%) compared to 2e2b223

Details

Codecov Report

Attention: Patch coverage is 71.87500% with 9 lines in your changes missing coverage. Please review.

Project coverage is 69.45%. Comparing base (2e2b223) to head (a107193).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/mysqlctl/builtinbackupengine.go 71.87% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16856      +/-   ##
==========================================
+ Coverage   69.43%   69.45%   +0.01%     
==========================================
  Files        1571     1571              
  Lines      203021   203099      +78     
==========================================
+ Hits       140970   141056      +86     
+ Misses      62051    62043       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.