-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add savepoint support to atomic distributed transaction #16863
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16863 +/- ##
==========================================
- Coverage 69.45% 69.42% -0.04%
==========================================
Files 1570 1570
Lines 203631 203921 +290
==========================================
+ Hits 141441 141563 +122
- Misses 62190 62358 +168 ☔ View full report in Codecov by Sentry. |
e006b04
to
3fae3af
Compare
…mit on it. added multiple e2e test cases Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
…rver Signed-off-by: Harshit Gangal <[email protected]>
4e8858b
to
e8ada40
Compare
Signed-off-by: Harshit Gangal <[email protected]>
a867d3d
to
69878ba
Compare
@@ -60,13 +59,13 @@ type ( | |||
|
|||
Stats *servenv.TimingsWrapper | |||
} | |||
Query struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add some comments? the type is not self evident, imho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from some nitpicks, LGTM
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Signed-off-by: Harshit Gangal <[email protected]>
Description
This PR adds support for savepoints usage in atomic distributed transaction commit by storing the savepoints in the transaction query log and then reapplying them on a recovery.
Related Issue(s)
Checklist
Deployment Notes