Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-19.0] Fix race in replicationLagModule of go/vt/throttle (#16078) #16899

Merged
merged 3 commits into from
Oct 7, 2024

empty commit

f52c313
Select commit
Loading
Failed to load commit list.
Merged

[release-19.0] Fix race in replicationLagModule of go/vt/throttle (#16078) #16899

empty commit
f52c313
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 5, 2024 in 0s

67.40% (+0.02%) compared to eff8a51

View this Pull Request on Codecov

67.40% (+0.02%) compared to eff8a51

Details

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.40%. Comparing base (eff8a51) to head (f52c313).

Files with missing lines Patch % Lines
go/vt/throttler/replication_lag_cache.go 91.30% 2 Missing ⚠️
go/vt/throttler/throttler.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #16899      +/-   ##
================================================
+ Coverage         67.38%   67.40%   +0.02%     
================================================
  Files              1560     1560              
  Lines            193329   193346      +17     
================================================
+ Hits             130266   130328      +62     
+ Misses            63063    63018      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.