Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-20.0] Fix race in replicationLagModule of go/vt/throttle (#16078) #16900

Merged
merged 2 commits into from
Oct 6, 2024

fix unit test

05e0083
Select commit
Loading
Failed to load commit list.
Merged

[release-20.0] Fix race in replicationLagModule of go/vt/throttle (#16078) #16900

fix unit test
05e0083
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 5, 2024 in 0s

68.68% (+0.01%) compared to f3313b1

View this Pull Request on Codecov

68.68% (+0.01%) compared to f3313b1

Details

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.68%. Comparing base (f3313b1) to head (05e0083).

Files with missing lines Patch % Lines
go/vt/throttler/replication_lag_cache.go 91.30% 2 Missing ⚠️
go/vt/throttler/throttler.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #16900      +/-   ##
================================================
+ Coverage         68.66%   68.68%   +0.01%     
================================================
  Files              1541     1541              
  Lines            197964   197981      +17     
================================================
+ Hits             135925   135974      +49     
+ Misses            62039    62007      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.