test: add warnings to planner tests

go/mysql/sqlerror/constants.go

@@ -220,6 +220,7 @@ const (
 	ERWrongFKDef                   = ErrorCode(1239)
 	ERKeyRefDoNotMatchTableRef     = ErrorCode(1240)
 	ERCyclicReference              = ErrorCode(1245)
+	ERAutoConvert                  = ErrorCode(1246)
 	ERIllegalReference             = ErrorCode(1247)
 	ERDerivedMustHaveAlias         = ErrorCode(1248)
 	ERTableNameNotAllowedHere      = ErrorCode(1250)

go/test/vschemawrapper/vschema_wrapper.go

@@ -51,6 +51,7 @@ type VSchemaWrapper struct {
 	EnableViews           bool
 	TestBuilder           func(query string, vschema plancontext.VSchema, keyspace string) (*engine.Plan, error)
 	Env                   *vtenv.Environment
+	Warnings              []*querypb.QueryWarning
 }
 
 func (vw *VSchemaWrapper) GetPrepareData(stmtName string) *vtgatepb.PrepareData {
@@ -132,7 +133,8 @@ func (vw *VSchemaWrapper) Environment() *vtenv.Environment {
 	return vw.Env
 }
 
-func (vw *VSchemaWrapper) PlannerWarning(_ string) {
+func (vw *VSchemaWrapper) PlannerWarnings(warnings ...*querypb.QueryWarning) {
+	vw.Warnings = warnings
 }
 
 func (vw *VSchemaWrapper) ForeignKeyMode(keyspace string) (vschemapb.Keyspace_ForeignKeyMode, error) {

go/vt/vtgate/planbuilder/plan_test.go

@@ -28,6 +28,11 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/stretchr/testify/assert"
+
+	"vitess.io/vitess/go/slice"
+	querypb "vitess.io/vitess/go/vt/proto/query"
+
 	"github.com/nsf/jsondiff"
 	"github.com/stretchr/testify/require"
 	"github.com/stretchr/testify/suite"
@@ -661,10 +666,11 @@ func createFkDefinition(childCols []string, parentTableName string, parentCols [
 
 type (
 	planTest struct {
-		Comment string          `json:"comment,omitempty"`
-		Query   string          `json:"query,omitempty"`
-		Plan    json.RawMessage `json:"plan,omitempty"`
-		Skip    bool            `json:"skip,omitempty"`
+		Comment  string          `json:"comment,omitempty"`
+		Query    string          `json:"query,omitempty"`
+		Plan     json.RawMessage `json:"plan,omitempty"`
+		Skip     bool            `json:"skip,omitempty"`
+		Warnings []string        `json:"warnings,omitempty"`
 	}
 )
 
@@ -688,6 +694,9 @@ func (s *planTestSuite) testFile(filename string, vschema *vschemawrapper.VSchem
 			}
 			vschema.Version = Gen4
 			out := getPlanOutput(tcase, vschema, render)
+			current.Warnings = slice.Map(vschema.Warnings, func(q *querypb.QueryWarning) string {
+				return q.String()
+			})
 
 			// our expectation for the planner on the query is one of three
 			// - produces same plan as expected
@@ -710,6 +719,9 @@ func (s *planTestSuite) testFile(filename string, vschema *vschemawrapper.VSchem
 				} else if tcase.Skip {
 					t.Errorf("query is correct even though it is skipped:\n %s", tcase.Query)
 				}
+				if !tcase.Skip {
+					assert.Equal(t, tcase.Warnings, current.Warnings)
+				}
 				current.Plan = []byte(out)
 			})
 			expected = append(expected, current)

go/vt/vtgate/planbuilder/plancontext/planning_context.go

@@ -101,7 +101,7 @@ func CreatePlanningContext(stmt sqlparser.Statement,
 	}
 
 	// record any warning as planner warning.
-	vschema.PlannerWarning(semTable.Warning)
+	vschema.PlannerWarnings(semTable.Warnings...)
 
 	return &PlanningContext{
 		ReservedVars:      reservedVars,

go/vt/vtgate/planbuilder/plancontext/planning_context_test.go

@@ -290,8 +290,7 @@ func (v *vschema) WarnUnshardedOnly(format string, params ...any) {
 	panic("implement me")
 }
 
-func (v *vschema) PlannerWarning(message string) {
-	// TODO implement me
+func (v *vschema) PlannerWarnings(...*querypb.QueryWarning) {
 	panic("implement me")
 }
 

go/vt/vtgate/planbuilder/plancontext/vschema.go

@@ -54,7 +54,7 @@ type VSchema interface {
 	WarnUnshardedOnly(format string, params ...any)
 
 	// PlannerWarning records warning created during planning.
-	PlannerWarning(message string)
+	PlannerWarnings(warnings ...*querypb.QueryWarning)
 
 	// ForeignKeyMode returns the foreign_key flag value
 	ForeignKeyMode(keyspace string) (vschemapb.Keyspace_ForeignKeyMode, error)

go/vt/vtgate/planbuilder/select.go

@@ -109,7 +109,7 @@ func gen4planSQLCalcFoundRows(vschema plancontext.VSchema, sel *sqlparser.Select
 		return nil, err
 	}
 	// record any warning as planner warning.
-	vschema.PlannerWarning(semTable.Warning)
+	vschema.PlannerWarnings(semTable.Warnings...)
 
 	plan, tablesUsed, err := buildSQLCalcFoundRowsPlan(query, sel, reservedVars, vschema)
 	if err != nil {

go/vt/vtgate/planbuilder/set.go

@@ -21,6 +21,9 @@ import (
 	"strconv"
 	"strings"
 
+	"vitess.io/vitess/go/mysql/sqlerror"
+	querypb "vitess.io/vitess/go/vt/proto/query"
+
 	"vitess.io/vitess/go/vt/key"
 	"vitess.io/vitess/go/vt/sqlparser"
 	"vitess.io/vitess/go/vt/sysvars"
@@ -92,7 +95,10 @@ func buildSetPlan(stmt *sqlparser.Set, vschema plancontext.VSchema) (*planResult
 				// This is to keep the backward compatibility.
 				// 'transaction_isolation' was added as a reserved connection system variable, so it used to change the setting at session level already.
 				// logging warning now to
-				vschema.PlannerWarning("converted 'next transaction' scope to 'session' scope")
+				vschema.PlannerWarnings(&querypb.QueryWarning{
+					Code:    uint32(sqlerror.ERAutoConvert),
+					Message: "converted 'next transaction' scope to 'session' scope",
+				})
 			}
 		case sqlparser.VitessMetadataScope:
 			value, err := getValueFor(expr)