-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PRS and ERS don't promote replicas taking backups #16997
Merged
deepthi
merged 24 commits into
vitessio:main
from
ejortegau:ejortegau/reparenting-skips-tablets-running-backups
Nov 21, 2024
Merged
Changes from 22 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b2c0b5c
PRS and ERS don't promote replicas taking backups
ejortegau e9fda77
Rebuild vtadmin proto files
ejortegau 8a196c9
Fix assignment to nil map
ejortegau d7b8ddd
Fix TestGRPCTMServer
ejortegau 2d22cf4
Improve error message.
ejortegau 54bdcc0
Address PR comments
ejortegau fc69610
Reorder some code to skip sorting not preferred tablets when we won't…
ejortegau f7bbd32
Merge branch 'main' into ejortegau/reparenting-skips-tablets-running-…
ejortegau 67f901d
Regenerate some code from proto after fixing merge conflicts
ejortegau 2819bf1
Add change info to changelog
ejortegau 92a11e0
Make linter happy
ejortegau 6db5006
Address PR comments
ejortegau 30114e5
Improve testing for skipping promoting host running backup
ejortegau ca7078e
Fix imports some more
ejortegau 6840803
Address PR comments
ejortegau 8b41ff1
Fix vtadmin proto stuff
ejortegau a29efa7
Fix more proto stuff
ejortegau 09331a9
Fix missing fields coming from renaming of proto fields +
ejortegau e315d12
More field renaming for betetr consistency
ejortegau 3405351
Address PR comment
ejortegau 86f0182
Merge branch 'main' into ejortegau/reparenting-skips-tablets-running-…
ejortegau 61ad1b6
Address PR comments
ejortegau 83f7b62
Run go run ./go/tools/releases/releases.go to make CI check happy
ejortegau 97c0271
Address PR comment
ejortegau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# Changelog of Vitess v22.0.0 | ||
|
||
### Enhancement | ||
#### Cluster management | ||
* Prefer not promoting replicas that are taking backups [#16997](https://github.com/vitessio/vitess/pull/16997) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this file will be generated when we do the first release candidate for v22. No need to create it right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was autogenerated when I ran a command indicated in a failing CI check.